Fix "karmor profile --save" command #472
Conversation
|
Output:
|
|
Sir, can you please review this. Let me know if this require any changes, I would love to learn about the best practices. |
There was a problem hiding this comment.
It works, tested locally. @Affan-7 kindly fix the ci-gosec failures
|
@Aryan-sharma11 fixed the gosec failure. |
There was a problem hiding this comment.
Let's reuse and refactor functions from recommend directory into utils to avoid complications and duplicate code
kubearmor-client/recommend/recommend.go
Line 81 in 9ad1b99
profile/Client/profileClient.go
Outdated
| err := os.MkdirAll(filepath, 0600) | ||
| err = os.WriteFile(filepath+Operation+".json", []byte(jsonArray[0]), 0600) | ||
| directory := "Profile_Summary/" | ||
| err := os.MkdirAll(directory, 0700) |
There was a problem hiding this comment.
| err := os.MkdirAll(directory, 0700) | |
| err := os.MkdirAll(directory, 0600) |
Why do we need exec permission?
There was a problem hiding this comment.
Without exec we can't cd into that directory, and we also can't create files. Here is the current behavior of 600 permission:
Signed-off-by: Mohammed Affan <[email protected]>
Fixes #381